Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17477#discussion_r111059834
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -704,12 +704,12 @@ private[spark] object TaskSchedulerImpl {
* Used to balance containers across hosts.
*
* Accepts a map of hosts to resource offers for that host, and returns
a prioritized list of
- * resource offers representing the order in which the offers should be
used. The resource
+ * resource offers representing the order in which the offers should be
used. The resource
* offers are ordered such that we'll allocate one container on each
host before allocating a
* second container on any host, and so on, in order to reduce the
damage if a host fails.
*
- * For example, given <h1, [o1, o2, o3]>, <h2, [o4]>, <h1, [o5, o6]>,
returns
- * [o1, o5, o4, 02, o6, o3]
+ * For example, given a map consisting of h1 to [o1, o2, o3], h2 to [o4]
and h3 to [o5, o6],
+ * returns a list, [o1, o5, o4, o2, o6, o3].
--- End diff --
Can we also wrap this in code or otherwise escape it or use a different
symbol?
```
{h1: [o1, o2, o3], h2: [o4], ...}
```
is clearer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
