Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17712#discussion_r112692504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -47,20 +47,31 @@ case class UserDefinedFunction protected[sql] (
dataType: DataType,
inputTypes: Option[Seq[DataType]]) {
- // Optionally used for printing UDF names in EXPLAIN
- private var nameOption: Option[String] = None
+ protected def name: Option[String] = None
- def withName(name: String): this.type = {
- this.nameOption = Option(name)
- this
- }
+ // Optionally used for printing UDF names in EXPLAIN
+ def withName(name: String): this.type =
+ UserDefinedFunctionWithName(Option(name), f, dataType, inputTypes)
/**
* Returns an expression that invokes the UDF, using the given arguments.
*
* @since 1.3.0
*/
def apply(exprs: Column*): Column = {
- Column(ScalaUDF(f, dataType, exprs.map(_.expr),
inputTypes.getOrElse(Nil), nameOption))
+ Column(ScalaUDF(f, dataType, exprs.map(_.expr),
inputTypes.getOrElse(Nil), name))
}
}
+
+/**
+ * A user-defined function with a function name.
+ *
+ * @since 2.3.0
+ */
+@InterfaceStability.Stable
+case class UserDefinedFunctionWithName protected[sql] (
+ override val name: Option[String],
--- End diff --
Can a `UserDefinedFunctionWithName` have **no** name? When?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
