Github user jaceklaskowski commented on the issue:

    https://github.com/apache/spark/pull/17727
  
    Fair enough. Let's do it here. Quoting directly from the code:
    
    > Converts a logical plan into zero or more SparkPlans.  This API is 
exposed for experimenting with the query planner and is not designed to be 
stable across spark releases.  Developers writing libraries should instead 
consider using the stable APIs provided in [[org.apache.spark.sql.sources]]
    
    > Converts a logical plan into zero or more SparkPlans.
    
    It does not. It's a type alias for something that may do so. And moreover 
it's copied from `SparkStrategy`. No need for repeating it here.
    
    > This API is exposed for experimenting with the query planner and is not 
designed to be stable across spark releases.
    
    That's the purpose of `@DeveloperApi` and `@InterfaceStability.Unstable` 
annotations so, yes, you're right, it's not misleading, but a repetition (that 
cannot be checked by the Scala compiler).
    
    > Developers writing libraries should instead consider using the stable 
APIs provided in [[org.apache.spark.sql.sources]]
    
    How does `org.apache.spark.sql.sources` help here?! `SparkStrategy` is 
about query planning not DataSource IO. They're at different levels and may 
interest different developers. Certainly misleading.
    
    WDYT?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to