Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/17130#discussion_r113366111
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -268,12 +269,8 @@ class FPGrowthModel private[ml] (
val predictUDF = udf((items: Seq[_]) => {
if (items != null) {
val itemset = items.toSet
- brRules.value.flatMap(rule =>
- if (items != null && rule._1.forall(item =>
itemset.contains(item))) {
- rule._2.filter(item => !itemset.contains(item))
- } else {
- Seq.empty
- }).distinct
+ brRules.value.filter(_._1.forall(itemset.contains))
+ .flatMap(_._2.filter(!itemset.contains(_))).distinct
--- End diff --
right, 2 things - first just calling out while the PR says doc changes
there is this one code change here.
second, before this code was checking `items != null` do we need not
consider that now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
