Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/17825#discussion_r114928655
--- Diff: R/pkg/R/generics.R ---
@@ -387,6 +387,16 @@ setGeneric("value", function(bcast) {
standardGeneric("value") })
#' @export
setGeneric("agg", function (x, ...) { standardGeneric("agg") })
+#' alias
+#'
+#' Set a new name for a Column or a SparkDataFrame. Equivalent to SQL "AS"
keyword.
--- End diff --
I guess we don't say `return a new Column` but more generally `return a
Column`
and in other cases we say `return a new SparkDataFrame`
so I guess it's a difference in wording.
I think what you propose is fine, though do you think it's confusing to say
`Equivalent to SQL "AS" keyword.` because that makes sense only for Column and
not the whole dataframe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
