Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16989#discussion_r116904487
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala ---
@@ -51,7 +59,10 @@ private[spark] class BlockStoreShuffleReader[K, C](
// Note: we use getSizeAsMb when no suffix is provided for backwards
compatibility
SparkEnv.get.conf.getSizeAsMb("spark.reducer.maxSizeInFlight",
"48m") * 1024 * 1024,
SparkEnv.get.conf.getInt("spark.reducer.maxReqsInFlight",
Int.MaxValue),
- SparkEnv.get.conf.getBoolean("spark.shuffle.detectCorrupt", true))
+ SparkEnv.get.conf.getLong("spark.reducer.maxReqSizeShuffleToMem",
200 * 1024 * 1024),
--- End diff --
let's also put the off-heap size conf in config object near the
`maxReqSizeShuffleToMem` , so that it's easy to see `maxReqSizeShuffleToMem` is
smaller than off-heap size by default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
