Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18329#discussion_r123418793
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -264,12 +281,12 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
df,
sink,
outputMode,
- useTempCheckpointLocation = true,
+ useTempCheckpointLocation = isTempCheckpointLocationAvailable,
trigger = trigger)
} else {
val (useTempCheckpointLocation, recoverFromCheckpointLocation) =
if (source == "console") {
- (true, false)
+ (isTempCheckpointLocationAvailable, false)
--- End diff --
@mgaido91 AFAIK whether `useTempCheckpointLocation` is `true` or `false` is
based on the type of `Sink`, here with your change, now the semantics are
changing to wether `tmpFs` equals `defaultFs` or `defaultFs` is local FS. So
looks like the semantics are different now. I'm not if it is a valid fix.
@zsxwing would you please help to review this patch? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
