Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/18414#discussion_r123889666
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -566,10 +566,15 @@ private[deploy] class Master(
// Update application state if executors are accepted and RUNNING
apps.foreach(appInfo => {
val app = idToApp(appInfo.id)
- if(app.executors.filter(_._2.state !=
ExecutorState.RUNNING).isEmpty) {
- app.state = ApplicationState.RUNNING
- logInfo(s"Application :: ${app.id} status updated to RUNNING
state")
- }})
+ apps.foreach(f = appInfo => {
+ val app = idToApp(appInfo.id)
+ if (app.executors.size > 0 &&
--- End diff --
It might be more clear to write this condition like this
```scala
if (app.executors.nonEmpty && app.executors.forall(_._2.state ==
ExecutorState.RUNNING))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
