Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17995#discussion_r123920437
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -45,7 +47,7 @@ private[feature] trait ImputerParams extends Params with
HasInputCols {
final val strategy: Param[String] = new Param(this, "strategy",
s"strategy for imputation. " +
s"If ${Imputer.mean}, then replace missing values using the mean value
of the feature. " +
s"If ${Imputer.median}, then replace missing values using the median
value of the feature.",
- ParamValidators.inArray[String](Array(Imputer.mean, Imputer.median)))
+ (value: String) => Array(Imputer.mean,
Imputer.median).contains(value.toLowerCase(Locale.ROOT)))
--- End diff --
Ditto.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
