Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18174#discussion_r123924134
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -123,6 +126,8 @@
this.inMemSorter = new ShuffleInMemorySorter(
this, initialSize,
conf.getBoolean("spark.shuffle.sort.useRadixSort", true));
this.peakMemoryUsedBytes = getMemoryUsage();
+ this.diskWriteBufferSize =
+ conf.getInt("spark.shuffle.spill.diskWriteBufferSize",
DISK_WRITE_BUFFER_SIZE);
--- End diff --
@cloud-fan
thanks for review it.
Thank you for your advice. I tried to fix it.
However, org.apache.spark.internal.config cannot be imported in the
ShuffleExternalSorter.java class
This modification will change the org.apache.spark.internal.config and
affect other code changes,
so I suggest using the PR to modify it. Do you agree?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
