Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123925897
--- Diff: R/pkg/R/functions.R ---
@@ -635,20 +652,16 @@ setMethod("dayofyear",
column(jc)
})
-#' decode
-#'
-#' Computes the first argument into a string from a binary using the
provided character set
-#' (one of 'US-ASCII', 'ISO-8859-1', 'UTF-8', 'UTF-16BE', 'UTF-16LE',
'UTF-16').
+#' @details
+#' \code{decode}: Computes the first argument into a string from a binary
using the provided
+#' character set.
#'
-#' @param x Column to compute on.
-#' @param charset Character set to use
+#' @param charset Character set to use (one of "US-ASCII", "ISO-8859-1",
"UTF-8", "UTF-16BE",
+#' "UTF-16LE", "UTF-16").
--- End diff --
Not a big deal as they contain same information. So, just rather a weak
opinion - it'd be nicer if we match this to Scala/Python too IMHO or just leave
as is. It's also fine to me as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
