GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/18419
[SPARK-20213][SQL][follow-up] introduce SQLExecution.ignoreNestedExecutionId
## What changes were proposed in this pull request?
in https://github.com/apache/spark/pull/18064, to work around the nested
sql execution id issue, we introduced several internal methods in `Dataset`,
like `collectInternal`, `countInternal`, `showInternal`, etc., to avoid nested
execution id.
However, this approach has poor expansibility. When we hit other nested
execution id cases, we may need to add more internal methods in `Dataset`.
Our goal is to ignore the nested execution id in some cases, and we can
have a better approach to achieve this goal, by introducing
`SQLExecution.ignoreNestedExecutionId`. Whenever we find a place which needs to
ignore the nested execution, we can just wrap the action with
`SQLExecution.ignoreNestedExecutionId`, and this is more expansible than the
previous approach.
The idea comes from
https://github.com/apache/spark/pull/17540/files#diff-ab49028253e599e6e74cc4f4dcb2e3a8R57
by @rdblue
## How was this patch tested?
existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark follow
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18419.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18419
----
commit 0795c16b4beaf70430e8dc62f135f99ac801960e
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2017-06-26T04:36:59Z
introduce SQLExecution.ignoreNestedExecutionId
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
