Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18496#discussion_r125522252
--- Diff: R/pkg/R/mllib_tree.R ---
@@ -374,6 +374,10 @@ setMethod("write.ml", signature(object =
"GBTClassificationModel", path = "chara
#' nodes. If TRUE, the algorithm will cache node IDs
for each instance. Caching
#' can speed up training of deeper trees. Users can
set how often should the
#' cache be checkpointed or disable it by setting
checkpointInterval.
+#' @param handleInvalid How to handle invalid data (unseen labels or NULL
values) in classification model.
+#' Supported options: "skip" (filter out rows with invalid data),
+#' "error" (throw an error), "keep" (put invalid
data in a special additional
--- End diff --
is "error" the default behavior? since we are doing `handleInvalid =
c("error", "skip", "keep")` could you add text to say it's the default. also
consider sorting the options - default first "error", then "keep", "skip" if we
are alphabetical?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
