Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18664#discussion_r131308903
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -3036,6 +3052,9 @@ def test_toPandas_arrow_toggle(self):
             pdf = df.toPandas()
             self.spark.conf.set("spark.sql.execution.arrow.enable", "true")
             pdf_arrow = df.toPandas()
    +        # need to remove timezone for comparison
    +        pdf_arrow["7_timestamp_t"] = \
    +            pdf_arrow["7_timestamp_t"].apply(lambda ts: 
ts.tz_localize(None))
    --- End diff --
    
    I talked to @gatorsmile and he suggested that we should have another 
configuration to control the behavior of `df.toPandas()` to handle timezone or 
not, the default behavior of which is to not handle it as the same as the 
current behavior.
    I'll submit a pr to do it with "without-Arrow" version asap and I'd like 
you to follow the behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to