Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19065#discussion_r136152805
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -91,4 +94,60 @@ object ProbabilisticClassifierSuite {
"thresholds" -> Array(0.4, 0.6)
)
+ /**
+ * Add test for prediction using the model with all combinations of
--- End diff --
Tiny nit: This could be reworded from the JIRA description.
How about:
Helper for testing that a ProbabilisticClassificationModel computes the
same predictions across all combinations of output columns
(rawPrediction/probability/prediction) turned on/off. Makes sure the output
column values match by comparing vs. the case with all 3 output columns turned
on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
