Github user smurching commented on the issue:

    https://github.com/apache/spark/pull/17014
  
    @WeichenXu123 That approach sounds reasonable to me. 
    
    My main thought (& this might be obvious) is on the implementation level -- 
as long as we implement this by adding an `org.apache.spark.ml.Param` named 
`handlePersistence`, I think we can maintain binary compatibility. I'd be 
concerned about making `handlePersistence` an argument to `fit()`, which seems 
like it might [break binary 
compatibility](https://wiki.eclipse.org/Evolving_Java-based_APIs_2#Evolving_API_classes_-_API_methods_and_constructors).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to