Github user lgrcyanny commented on a diff in the pull request:
https://github.com/apache/spark/pull/19102#discussion_r136738525
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -496,7 +496,7 @@ object SparkSubmit extends CommandLineUtils with
Logging {
sysProp = "spark.executor.memory"),
OptionAssigner(args.totalExecutorCores, STANDALONE | MESOS,
ALL_DEPLOY_MODES,
sysProp = "spark.cores.max"),
- OptionAssigner(args.files, LOCAL | STANDALONE | MESOS,
ALL_DEPLOY_MODES,
+ OptionAssigner(args.files, ALL_CLUSTER_MGRS, ALL_DEPLOY_MODES,
--- End diff --
For yarn-client mode, --files are are already added to
"spark.yarn.dist.files", I agree with you that, just addFile in SparkContext
for yarn-client mode for "spark.yarn.dist.files". BTW, I will fix the doc for
Spark-Submit either.
Thanks @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
