Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18931#discussion_r136742515
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala ---
    @@ -89,6 +89,8 @@ case class ExpandExec(
         child.asInstanceOf[CodegenSupport].inputRDDs()
       }
     
    +  override protected def doConsumeInChainOfFunc: Boolean = false
    --- End diff --
    
    The `doConsume` produces something like:
    
           |for (int $i = 0; $i < ${projections.length}; $i ++) {
           |  switch ($i) {
           |    ${cases.mkString("\n").trim}
           |  }
           |  $numOutput.add(1);
           |  ${consume(ctx, outputColumns)}
           |}
    
    So the consume logic of its parent node is actually wrapped in a local 
for-loop. It has the same effect as not chain the next consume.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to