Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19086#discussion_r136747432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -569,46 +569,51 @@ class SessionCatalog(
/**
* Rename a table.
*
- * If a database is specified in `oldName`, this will rename the table
in that database.
+ * If the database specified in `newName` is different from the one
specified in `oldName`,
+ * It will result in moving table across databases.
+ *
* If no database is specified, this will first attempt to rename a
temporary table with
- * the same name, then, if that does not exist, rename the table in the
current database.
+ * the same name, then, if that does not exist, current database will be
used for locating
+ * `oldName` or `newName`.
--- End diff --
So should I make the comment here unchanged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
