Github user markhamstra commented on the issue:

    https://github.com/apache/spark/pull/19115
  
    I realize this PR is now closed, but to follow-up on Saisai's request 
concerning PR titles, I'll also note that the title of this PR isn't very 
useful even after the JIRA id and component tag are added. Titles like "fixed 
foo" or "updated bar" don't really tell reviewers or those looking at the 
commit logs in the future what the PR is about. The JIRA should tell us _why_ a 
change or addition is needed, the description in the PR should tell us _what_ 
was changed or added, and the PR title should give us enough of an idea of what 
is going on that we don't necessarily have to open the PR or look at the code 
changes just to see whether it is something that we are even at all interested 
in.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to