Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19124#discussion_r136878102
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
    @@ -169,6 +171,16 @@ class OrcFileFormat extends FileFormat with 
DataSourceRegister with Serializable
           }
         }
       }
    +
    +  private def checkFieldName(name: String): Unit = {
    +    // ,;{}()\n\t= and space are special characters in ORC schema
    --- End diff --
    
    Thank you for review, @tejasapatil !
    That's a good idea. Right, It's not an exhaustive list. I'll update the PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to