Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r137441814
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -48,6 +48,13 @@ public long size() {
}
/**
+ * Reset the size of the memory block.
+ */
--- End diff --
It is dangerous to reset to a invalid size. We should add a check here or
put a WARNING in the method comment.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
