Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r137706345
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -26,20 +26,50 @@ import
org.apache.spark.sql.catalyst.expressions.SpecializedGetters
import org.apache.spark.sql.catalyst.util.{ArrayData, DateTimeUtils,
MapData}
import org.apache.spark.sql.types._
+// `JackGenerator` can only be initialized with a `StructType` or a
`MapType`.
+// Once it is initialized with `StructType`, it can be used to write out a
struct or an array of
+// struct. Once it is initialized with `MapType`, it can be used to write
out a map. An exception
+// will be thrown if trying to write out a struct if it is initialized
with a `MapType`,
+// and vice verse.
--- End diff --
For this kind of comment, we use the style like:
/**
* Code comments...
*
*/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
