Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19185#discussion_r138220213
--- Diff: python/pyspark/ml/tests.py ---
@@ -1473,11 +1473,59 @@ def test_logistic_regression_summary(self):
self.assertTrue(isinstance(s.fMeasureByThreshold, DataFrame))
self.assertTrue(isinstance(s.precisionByThreshold, DataFrame))
self.assertTrue(isinstance(s.recallByThreshold, DataFrame))
+
+ self.assertAlmostEqual(s.accuracy, 1.0, 2)
--- End diff --
also nit, but should probably add tests for all the new attributes, like
`falsePositiveRateByLabel` as below.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
