Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/19186#discussion_r138243247
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -444,13 +444,13 @@ class LogisticRegressionWithLBFGS
lr.setFitIntercept(addIntercept)
lr.setMaxIter(optimizer.getNumIterations())
lr.setTol(optimizer.getConvergenceTol())
+ // Determine if we should cache the DF
+ lr.setHandlePersistence(input.getStorageLevel == StorageLevel.NONE)
--- End diff --
`mlllib.LoR` do not expose `HandlePersistence` to users now, and I think it
maybe better to keep it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
