Github user caneGuy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19132#discussion_r138523362
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/AllStagesResource.scala ---
    @@ -142,7 +142,7 @@ private[v1] object AllStagesResource {
           index = uiData.taskInfo.index,
           attempt = uiData.taskInfo.attemptNumber,
           launchTime = new Date(uiData.taskInfo.launchTime),
    -      duration = uiData.taskDuration,
    +      duration = uiData.taskDuration(),
    --- End diff --
    
    You are right, @jerryshao .IIUC, the `ui` in `AllStagesResource.scala` is 
passed from `ApiRootResource` which also create `sparkUI` by 
`FSHistoryProvider`.So we can also get `lastUpdateTime` from this `ui` in 
`AllStagesResource` and pass to the `taskDuration` interface.I think it is 
another problem for REST?Should we fix here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to