Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19231#discussion_r138800677
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -993,7 +996,10 @@ class JDBCSuite extends SparkFunSuite
Seq(StructField("NAME", StringType, true), StructField("THEID",
IntegerType, true)))
val df = sql("select * from people_view")
assert(df.schema.size === 2)
- assert(df.schema === schema)
--- End diff --
revert it back.
Change the following line
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L309
to
```
fields(i) = StructField(columnName, columnType, nullable)
```
You also need to update some test cases due to the above change, I think.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
