Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19130#discussion_r138801682
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -897,6 +897,80 @@ class SparkSubmitSuite
         sysProps("spark.submit.pyFiles") should (startWith("/"))
       }
     
    +  test("handle remote http(s) resources in yarn mode") {
    +    val hadoopConf = new Configuration()
    +    updateConfWithFakeS3Fs(hadoopConf)
    +
    +    val tmpDir = Utils.createTempDir()
    +    val mainResource = File.createTempFile("tmpPy", ".py", tmpDir)
    +    val tmpJar = TestUtils.createJarWithFiles(Map("test.resource" -> 
"USER"), tmpDir)
    +    val tmpJarPath = s"s3a://${new File(tmpJar.toURI).getAbsolutePath}"
    +    // This assumes UT environment could access external network.
    --- End diff --
    
    Yes, that's my concern, let me think out another way to handle this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to