Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19240#discussion_r139042816
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -2256,7 +2256,10 @@ object CleanupAliases extends Rule[LogicalPlan] {
     
       def trimNonTopLevelAliases(e: Expression): Expression = e match {
         case a: Alias =>
    -      a.withNewChildren(trimAliases(a.child) :: Nil)
    --- End diff --
    
    Is there anywhere else in the code base where we call `withNewChildren` on 
an alias?  Should we just override that?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to