Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19244#discussion_r139281714 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/GenFuncTransformer.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.ml.feature + +import scala.util.Random + +import org.apache.spark.annotation.Since +import org.apache.spark.ml.Transformer +import org.apache.spark.ml.param.Param +import org.apache.spark.ml.param.ParamMap +import org.apache.spark.ml.param.shared.HasInputCols +import org.apache.spark.ml.param.shared.HasOutputCol +import org.apache.spark.ml.util.DefaultParamsReadable +import org.apache.spark.ml.util.DefaultParamsWritable +import org.apache.spark.ml.util.Identifiable +import org.apache.spark.sql.DataFrame +import org.apache.spark.sql.Dataset +import org.apache.spark.sql.Row +import org.apache.spark.sql.catalyst.encoders.RowEncoder +import org.apache.spark.sql.types.DoubleType +import org.apache.spark.sql.types.NumericType +import org.apache.spark.sql.types.StructField +import org.apache.spark.sql.types.StructType + +import javax.script.ScriptEngineManager --- End diff -- I think introducing Javascript is a non-starter
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org