Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19259#discussion_r139333133
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala 
---
    @@ -913,6 +913,25 @@ class JDBCSuite extends SparkFunSuite
           "dbtable" -> "t1",
           "numPartitions" -> "10")
         assert(new JDBCOptions(parameters).asConnectionProperties.isEmpty)
    -    assert(new JDBCOptions(new 
CaseInsensitiveMap(parameters)).asConnectionProperties.isEmpty)
    +    assert(new 
JDBCOptions(CaseInsensitiveMap(parameters)).asConnectionProperties.isEmpty)
    +  }
    +
    +  test("SPARK-19318: jdbc data source options should be treated 
case-insensitive.") {
    --- End diff --
    
    Where is the test case `test("SPARK-19318: Connection properties keys 
should be case-sensitive.")`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to