Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r139861892
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -117,6 +118,12 @@ public void fetchBlocks(
}
}
+ @Override
+ public MetricSet shuffleMetrics() {
+ checkInit();
--- End diff --
Seems it should be, but looks like we never touch this issue before.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
