Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19281#discussion_r139875333
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
    @@ -64,6 +67,42 @@ class JoinSuite extends QueryTest with SharedSQLContext {
         }
       }
     
    +  def assertJoinOrdering(sqlString: String, numOfJoin: Int, numOfSort: 
Int): Any = {
    --- End diff --
    
    Please add function comments to explain what it does 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to