Github user caneGuy commented on the issue:

    https://github.com/apache/spark/pull/19168
  
    Sorry for replying so late.
    I add some benchmark testing for this pr @kiszk .
    And @jerryshao could you help review this pr?Thanks
    ```
    Running benchmark: Benchmark fetch before vs after releasing buffer
      Running case: Testing fetch before releasing!
      Stopped after 10 iterations, 2423 ms
      Running case: Testing fetch after releasing!
      Stopped after 18 iterations, 2036 ms
    
    Java HotSpot(TM) 64-Bit Server VM 1.8.0_25-b17 on Linux 4.4.0-64-generic
    Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
    Benchmark fetch before vs after releasing buffer: Best/Avg Time(ms)    
Rate(M/s)   Per Row(ns)   Relative
    
------------------------------------------------------------------------------------------------
    Testing fetch before releasing!                 46 /  242        345.0      
     2.9       1.0X
    Testing fetch after releasing!                  73 /  113        215.7      
     4.6       0.6X
    ```
    ```
    Running benchmark: Benchmark fetch before vs after releasing buffer
      Running case: Testing fetch before releasing!
      Stopped after 10 iterations, 3888 ms
      Running case: Testing fetch after releasing!
      Stopped after 10 iterations, 3970 ms
    
    Java HotSpot(TM) 64-Bit Server VM 1.8.0_25-b17 on Linux 4.4.0-64-generic
    Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
    Benchmark fetch before vs after releasing buffer: Best/Avg Time(ms)    
Rate(M/s)   Per Row(ns)   Relative
    
------------------------------------------------------------------------------------------------
    Testing fetch before releasing!                100 /  389        157.8      
     6.3       1.0X
    Testing fetch after releasing!                 151 /  397        104.3      
     9.6       0.7X
    ```
    ```
    Running benchmark: Benchmark fetch before vs after releasing buffer
      Running case: Testing fetch before releasing!
      Stopped after 15 iterations, 2016 ms
      Running case: Testing fetch after releasing!
      Stopped after 14 iterations, 2110 ms
    
    Java HotSpot(TM) 64-Bit Server VM 1.8.0_25-b17 on Linux 4.4.0-64-generic
    Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
    Benchmark fetch before vs after releasing buffer: Best/Avg Time(ms)    
Rate(M/s)   Per Row(ns)   Relative
    
------------------------------------------------------------------------------------------------
    Testing fetch before releasing!                 43 /  134        363.8      
     2.7       1.0X
    Testing fetch after releasing!                  99 /  151        158.1      
     6.3       0.4X
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to