Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18015#discussion_r140416046
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ---
    @@ -61,7 +59,37 @@ private[ui] class AllExecutionsPage(parent: SQLTab) 
extends WebUIPage("") with L
               
details.parentNode.querySelector('.stage-details').classList.toggle('collapsed')
             }}
           </script>
    -    UIUtils.headerSparkPage("SQL", content, parent, Some(5000))
    +
    +    val summary: NodeSeq =
    +      <div>
    +        <ul class="unstyled">
    +          {
    +          if (listener.getRunningExecutions.nonEmpty) {
    +            <li>
    +              <a href="#running-execution-table"><strong>Running 
Queries:</strong></a>
    +              {listener.getRunningExecutions.size}
    +            </li>
    +          }
    +          }
    +          {
    +          if (listener.getCompletedExecutions.nonEmpty) {
    +            <li id="completed-summary">
    +              <a href="#completed-execution-table"><strong>Completed 
Queries:</strong></a>
    +              {listener.getCompletedExecutions.size}
    +            </li>
    +          }
    +          }
    +          {
    +          if (listener.getFailedExecutions.nonEmpty) {
    +            <li>
    +              <a href="#failed-execution-table"><strong>Failed 
Queries:</strong></a>
    +              {listener.getFailedExecutions.size}
    +            </li>
    +          }
    +          }
    --- End diff --
    
    Is the indention here correct? This seems a little weird to me.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to