Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19327#discussion_r140605142
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -146,7 +146,13 @@ case class StreamingSymmetricHashJoinExec(
stateWatermarkPredicates = JoinStateWatermarkPredicates(), left,
right)
}
- require(joinType == Inner, s"${getClass.getSimpleName} should not take
$joinType as the JoinType")
+ private lazy val badJoinTypeException =
--- End diff --
This should be a def. I dont think exceptions should be created and thrown
later. I am not sure whether it will capture the stack trace of when it was
created or when it was thrown. Either way its a bad pattern to have. A better
approach is to make it into a function `def throwBadJoinTypeException() { throw
new ... }`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
