Github user WeichenXu123 commented on the issue:

    https://github.com/apache/spark/pull/19317
  
    Yes. I guess the perf gain is because, this PR use local hashmap which can 
use unlimited memory, but current spark aggregation impl, will auto spill local 
hashmap when exceeding a threshold.
    Memory management is a difficult thing we should not try to do it in user 
code I think, because we're hard to estimate how huge the hashmap will grow to.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to