Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19295#discussion_r140624052
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala ---
@@ -78,8 +82,14 @@ class SQLContextSuite extends SparkFunSuite with
SharedSparkContext {
test("Catalyst optimization passes are modifiable at runtime") {
val sqlContext = SQLContext.getOrCreate(sc)
- sqlContext.experimental.extraOptimizations = Seq(DummyRule)
-
assert(sqlContext.sessionState.optimizer.batches.flatMap(_.rules).contains(DummyRule))
+ sqlContext.experimental.extraOptimizations =
Seq(DummyPostOptimizationRule)
+ sqlContext.experimental.extraPreOptimizations =
Seq(DummyPreOptimizationRule)
+
+ val firstBatch = sqlContext.sessionState.optimizer.batches.head
+ val lastBatch = sqlContext.sessionState.optimizer.batches.last //
.flatMap(_.rules)
--- End diff --
is the comment useful?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
