Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19324#discussion_r140664581
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
 ---
    @@ -186,8 +186,7 @@ case class BroadcastHashJoinExec(
        */
       private def getJoinCondition(
           ctx: CodegenContext,
    -      input: Seq[ExprCode],
    -      anti: Boolean = false): (String, String, Seq[ExprCode]) = {
    --- End diff --
    
    I like this change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to