Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140788231
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -93,6 +104,8 @@ class TaskInfo(
def running: Boolean = !finished
+ def needResubmit: Boolean = !killedAttempt
--- End diff --
Since `killedAttempt`/`killedByAttempt` is never used except in this
negated sense, it probably makes more sense to get rid of it and this
`needResubmit` method entirely, and just have a `needResubmit` var with the
opposite sense of `killedAttempt` -- but I'm also not all that happy with the
`needResubmit` name.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
