GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/19344
[SPARK-22122][SQL] Respect WITH clauses to count input rows in
TPCDSQueryBenchmark
## What changes were proposed in this pull request?
Since the current code ignores WITH clauses to check input relations in
TPCDS queries, this leads to inaccurate per-row processing time for benchmark
results. For example, in `q2`, this fix could catch all the input relations:
`web_sales`, `date_dim`, and `catalog_sales` (the current code catches
`date_dim` only). The one-third of the TPCDS queries uses WITH clauses, so I
think it is worth fixing this.
## How was this patch tested?
Manually checked.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maropu/spark RespectWithInTPCDSBench
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19344
----
commit d9be37e9e3168d4adb340bb82a48006863c11636
Author: Takeshi Yamamuro <yamam...@apache.org>
Date: 2017-09-25T11:12:50Z
Respect With in TPCDSQueryBenchmark
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
