Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19342#discussion_r140957870
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3250,6 +3250,7 @@ setMethod("attach",
function(what, pos = 2, name = deparse(substitute(what)),
warn.conflicts = TRUE) {
newEnv <- assignNewEnv(what)
attach(newEnv, pos = pos, name = name, warn.conflicts =
warn.conflicts)
+ on.exit(detach(newEnv, pos = pos, name = name))
--- End diff --
The reported point is a NOTE, as per my understanding, we should be able to
release with a NOTE (in fact, there is another NOTE on an unknown maintainer...)
Also, I'm not sure how by addition this would address the NOTE? From what I
can see, the NOTE says we should be careful about having an `attach` method...
for which I see the only way to address it or to avoid the NOTE is... to remove
the `attach` method?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
