[GitHub] spark pull request #19168: [SPARK-21956][CORE] Fetch up to max bytes when bu...

[caneGuy]

Github user caneGuy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19168#discussion_r141228856
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala 
---
    @@ -439,6 +443,8 @@ final class ShuffleBlockFetcherIterator(
                       fetchRequests += FetchRequest(address, Array((blockId, 
size)))
                       result = null
                     }
    +                bytesInFlight -= size
    +                fetchUpToMaxBytes()
    --- End diff --
    
    Thanks @cloud-fan 
    IIUC, i think when  `fetchfailedException` thrown there is no need to 
consider this.Which is also the original design.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org