Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19407#discussion_r142022819
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala 
---
    @@ -269,7 +269,7 @@ final class DataStreamWriter[T] private[sql](ds: 
Dataset[T]) {
         } else {
           val (useTempCheckpointLocation, recoverFromCheckpointLocation) =
             if (source == "console") {
    -          (true, false)
    +          (true, true)
    --- End diff --
    
    Is there any source that uses `recoverFromCheckpointLocation` disabled? 
What's the use case if any?
    
    Remove  `recoverFromCheckpointLocation` here as it's always `true` and make 
it explicit.
    
    The JIRA issue is to fix the exception followed by cleaning the code that 
was needed in the past.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to