Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19083#discussion_r142058489
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -1020,6 +1006,10 @@ abstract class CodeGenerator[InType <: AnyRef, 
OutType <: AnyRef] extends Loggin
     }
     
     object CodeGenerator extends Logging {
    +
    +  // This is the value of HugeMethodLimit in the OpenJDK JVM settings
    +  val DEFAULT_OPENJDK_JVM_HUGE_METHOD_LIMIT = 8000
    --- End diff --
    
    I think just `DEFAULT_JVM_HUGE_METHOD_LIMIT` is ok. The comment already 
explains it is from OpenJDK.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to