Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19418#discussion_r142848020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -697,7 +697,12 @@ class CodegenContext {
}
"""
s"${addNewFunction(compareFunc, funcCode)}($c1, $c2)"
- case other if other.isInstanceOf[AtomicType] => s"$c1.compare($c2)"
+ case other if other.isInstanceOf[AtomicType] =>
+ if (s"$c1".getClass.getMethods.map(_.getName).filter(_ matches
"compare").size == 1) {
--- End diff --
@viirya i was putting a note to that effect :-) This would not work, but
trying out something, especially the consistency betn local and jenkins test
behavior.I needed "other" to work.Anyhow, mainly looking to check if
atomictypes conv/long/String can happen by different attempts.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
