Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19061#discussion_r143073586
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -399,6 +399,18 @@ class SparkSubmitSuite
         mainClass should be ("org.apache.spark.deploy.yarn.Client")
       }
     
    +  test("SPARK-21568 ConsoleProgressBar should be enabled only in shells") {
    +    val clArgs1 = Seq("--class", "org.apache.spark.repl.Main", 
"spark-shell")
    +    val appArgs1 = new SparkSubmitArguments(clArgs1)
    +    val (_, _, sysProps1, _) = prepareSubmitEnvironment(appArgs1)
    +    sysProps1("spark.ui.showConsoleProgress") should be ("true")
    +
    +    val clArgs2 = Seq("--class", "org.SomeClass", "thejar.jar")
    +    val appArgs2 = new SparkSubmitArguments(clArgs2)
    +    val (_, _, sysProps2, _) = prepareSubmitEnvironment(appArgs2)
    +    sysProps2.keys should not contain "spark.ui.showConsoleProgress"
    --- End diff --
    
    `UI_SHOW_CONSOLE_PROGRESS.key`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to