Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19419#discussion_r143113850
  
    --- Diff: conf/spark-defaults.conf.template ---
    @@ -25,3 +25,10 @@
     # spark.serializer                 
org.apache.spark.serializer.KryoSerializer
     # spark.driver.memory              5g
     # spark.executor.extraJavaOptions  -XX:+PrintGCDetails -Dkey=value 
-Dnumbers="one two three"
    +
    +#spark.ui.allowFramingFrom         https://www.example.com/
    +#spark.ui.xXssProtection           1; mode=block
    +#spark.ui.xContentType.options     nosniff
    +
    +#Enable below only when Spark is running on HTTPS
    +#spark.ui.strictTransportSecurity  max-age=31536000
    --- End diff --
    
    Could you add a space after `#` and an empty line at the end of file?
    ```
    # spark.ui.allowFramingFrom         https://www.example.com/
    # spark.ui.xXssProtection           1; mode=block
    # spark.ui.xContentType.options     nosniff
    
    # Enable below only when Spark is running on HTTPS
    # spark.ui.strictTransportSecurity  max-age=31536000
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to