Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r143321347
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -181,7 +181,7 @@ class WholeStageCodegenSuite extends SparkPlanTest with
SharedSQLContext {
val codeWithShortFunctions = genGroupByCode(3)
val (_, maxCodeSize1) = CodeGenerator.compile(codeWithShortFunctions)
assert(maxCodeSize1 <
SQLConf.WHOLESTAGE_HUGE_METHOD_LIMIT.defaultValue.get)
- val codeWithLongFunctions = genGroupByCode(20)
+ val codeWithLongFunctions = genGroupByCode(50)
--- End diff --
In my pr, I changed the code to just check if long functions have the
larger value of max code size:
https://github.com/apache/spark/pull/19082/files#diff-0314224342bb8c30143ab784b3805d19R185
but, just increasing the value seems better.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
