Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19467#discussion_r144154295
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
 ---
    @@ -590,10 +590,33 @@ case class CoalesceExec(numPartitions: Int, child: 
SparkPlan) extends UnaryExecN
       }
     
       protected override def doExecute(): RDD[InternalRow] = {
    -    child.execute().coalesce(numPartitions, shuffle = false)
    +    if (numPartitions == 1 && child.execute().getNumPartitions < 1) {
    --- End diff --
    
    Add a test in DatasetSuite that tests this empty rdd case. maybe in the 
same test as the existing coalesce test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to